rmuir commented on PR #12207: URL: https://github.com/apache/lucene/pull/12207#issuecomment-1476657449
i'm suspicious of the benchmarking, we shouldn't be taking any benchmarks of 10k/1m seriously. only the 10m is reasonably reliable. And I don't see any real improvements there? But also, i don't understand why this change is supposed to make anything faster. AutomatonTermsEnum already has the appropriate optimization: https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/index/AutomatonTermsEnum.java#L149-L153 Maybe something similar could be improved in BlockTreeTermsReader.intersect() to speed it up more for the default codec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
