s1monw commented on code in PR #12205:
URL: https://github.com/apache/lucene/pull/12205#discussion_r1140021701
##########
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java:
##########
@@ -634,7 +652,9 @@ private void pruneBlockedQueue(final
DocumentsWriterDeleteQueue flushingQueue) {
iterator.remove();
addFlushingDWPT(blockedFlush);
// don't decr pending here - it's already done when DWPT is blocked
+ assert numQueued == flushQueue.size();
Review Comment:
All I was referring to was why we don't do `numQueued++` and `numQueued--`
in the corresponding places instead of `numQueued=flushQueue.size()` I don't
think we should put _blocked_ in there since we can't really do anything with
it for the time being but I haven't thought about it too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
