uschindler commented on PR #12188: URL: https://github.com/apache/lucene/pull/12188#issuecomment-1457689158
> I like it, Uwe. I have no idea about legal implications (whether interfaces alone are something that can be copied over). > > The only thing I've been wondering about is this: if these apis are still shaping and something changes upstream in the JDK, this change would go unnoticed. Do we rely on a periodic refresh of those API jars only? Or should we actually verify (in check) that the APIs are identical if the given JDK is available? For JDK 19 and JDK 20 the "API changes" phase is over. The final release candidate is out and if those would be rebuilt or get a new release, the API won't change anymore. Of course we can execute "regenerate" for safety on March 21, but the above files were generated with the version to be released on that day already. I would only add Java 21 once we are at a place when the API is finalized, which is not yet the sagte. Chronological checks are not needed, as once JDK 19 / 20 are/were released the APIs are final. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
