jpountz commented on PR #12139: URL: https://github.com/apache/lucene/pull/12139#issuecomment-1433116951
I removed type guessing by adding a new `IndexableField#invertableType` that can be either `TERM` or `TOKEN_STREAM`. The type guessing is now contained in `Field.java`. Initially I wanted to contain everything through something that would like more like a value type, like `StoredValue` but fields must be able to customize the way that they produce their token stream and I didn't like requiring `IndexableField` implementations to provide both an implementation for the `IndexableField` and for this abstraction that produces terms or token streams. I'm curious if you have thoughts on ways to make the API better @rmuir. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
