tylerbertrand opened a new pull request, #12150:
URL: https://github.com/apache/lucene/pull/12150

   ## Description
   
   <!--
   If this is your first contribution to Lucene, please make sure you have 
reviewed the contribution guide.
   https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
   -->
   
   Ported recent build improvements from Apache Solr 
([#1319](https://github.com/apache/solr/pull/1319) and 
[#1345](https://github.com/apache/solr/pull/1345)) with some modifications.
   
   In addition, the following build issues were addressed:
   1. Task `validateSourcePatterns` was including the `.gradle` directory for 
both `buildSrc` and `dev-tools/missing-doclet` as inputs, causing this task to 
not be cacheable.
      * Resolved by excluding all `.gradle` directories as inputs to 
`validateSourcePatterns`, not just the `.gradle` directory for the root project.
   2. With the changes to `copyTestResources`/`processTestResources`, the test 
`TestCustomAnalyzer.testStopWordsFromFile` was failing because `teststop.txt` 
was no longer at the root of the classes directory.
      * Resolved by following the convention set by other tests: providing the 
path to the file with `this.getDataPath("teststop.txt").toString()`
   
   ## Improvements
   
   Improved overall build time:
     * [Build scan timeline summary before 
changes](https://scans.gradle.com/s/wyryx5onlnlls#timeline)
     * [Build scan timeline summary after 
changes](https://scans.gradle.com/s/qupifnuiysdfq#timeline)
   
   Reduced number of executed cacheable tasks (cache misses):
     * [Build scan before 
changes](https://scans.gradle.com/s/wyryx5onlnlls/timeline?cacheability=cacheable&outcome=success,failed&sort=longest)
     * [Build scan after 
changes](https://scans.gradle.com/s/qupifnuiysdfq/timeline?cacheability=cacheable&outcome=success,failed)
   
   Improved the number of cacheable tasks:
     * [Non-cacheable tasks before 
changes](https://scans.gradle.com/s/wyryx5onlnlls/timeline?cacheability=any-non-cacheable&outcome=success,failed&sort=longest)
     * [Non-cacheable tasks after 
changes](https://scans.gradle.com/s/qupifnuiysdfq/timeline?cacheability=any-non-cacheable&outcome=success,failed)
   
   Reduced the number of eagerly created tasks:
     * [Eagerly created tasks before 
changes](https://scans.gradle.com/s/wyryx5onlnlls/performance/configuration#summary-task-created-immediately)
     * [Eagerly created tasks after 
changes](https://scans.gradle.com/s/qupifnuiysdfq/performance/configuration#summary-task-created-immediately)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to