jtibshirani commented on PR #12146: URL: https://github.com/apache/lucene/pull/12146#issuecomment-1428789703
The context: I've been testing out an AI code assistant, and I asked it if there were any bugs in `AbstractKnnVectorQuery`. It pointed out that "'advanceShallow' should move the 'upTo' field like 'nextDoc' does" ... which didn't seem right, but made me realize this logic looked funny. I'm not an expert in the doc skipping code, and had trouble fully understanding the method contracts. So let me know if this is off! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
