gsmiller commented on PR #12129: URL: https://github.com/apache/lucene/pull/12129#issuecomment-1418283281
Good catch on the lack of `scoreSupplier` resulting in all the ordinal lookups. The multivalued optimization is nice as well. The change looks good to me. I'll see if I can repurpose the benchmarking methodology I've been using for term-in-set query stuff tomorrow to see how this change helps there (I've confirmed with profiling that the ordinal lookups are contributing significantly to the cost of the `IndexOrDV` approach in some of the tasks, so this will help there) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
