rmuir commented on PR #12118: URL: https://github.com/apache/lucene/pull/12118#issuecomment-1410515203
I'm ok with changes but i still don't understand the use-case. Pulling all documents containing features, then calculating your own score throws away all the efficiency of FeatureField (e.g. early termination) and will be way too slow as the worst-case is scoring `O(maxdoc)` which could be e.g. a billion. It would be better to look at `Rescorer` api, e.g. keep the scores ON for the FeatureField, but pull top 500 or 1000 and re-rank those with anything fancy. It keeps everything fast and bounded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
