rmuir commented on PR #12116: URL: https://github.com/apache/lucene/pull/12116#issuecomment-1406967754
This is great, thanks for looking into it. It moves "type-guessing" into the one place that should be doing it, which is the generic Field.java i didn't really think too deeply about implementation but I suppose there might be a few options: * "Box" the value along with its type, like what you've done here (are there perf implications?) * change api of the visitor, e.g. to provide field's type (like the enum inside your current "box") before the value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
