zhaih commented on PR #12050: URL: https://github.com/apache/lucene/pull/12050#issuecomment-1382268387
+1, That sounds good! On Fri, Jan 13, 2023, 11:10 John Mazanec ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java > <https://github.com/apache/lucene/pull/12050#discussion_r1069901702>: > > > @@ -94,36 +93,83 @@ public int size() { > } > > /** > - * Add node on the given level > + * Add node on the given level. Nodes can be inserted out of order, but it requires that the nodes > > Oh I see what you mean. Yes, that makes sense. > > I think for level 0, we will still want to use a List because all nodes > will eventually be present in this level. However, for levels > 0, we can > use a TreeMap and then add an iterator over the keys of that map. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/lucene/pull/12050#discussion_r1069901702>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AEFSB7CTOHHMPL4YNBM6ZLTWSGSC7ANCNFSM6AAAAAATNF2BCI> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
