rmuir commented on PR #12013: URL: https://github.com/apache/lucene/pull/12013#issuecomment-1374852106
OK, crazy that having no cache at all could cause unnecessary amounts of flush/reopens. We want at least a small one. > I can close this PR and make that change if it makes sense. Or we can merge this change and take it up in a separate issue. Are there faceting specific benchmarks that can help validate the change? +1 to make the LRU cache the default. And please, lets also remove this ThreadLocal-based cache **completely** in main branch, and deprecate in 9.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
