rmuir commented on issue #12012: URL: https://github.com/apache/lucene/issues/12012#issuecomment-1347394601
Hmm, @dweiss I think it is still not quite right. I think we are not slowing down the `spotlessJava` task which is the one actually failing for me? Here's a simple reproducer patch to make compile fail in lucene/facet tests (which have dependencies on lucene core compile etc and are pretty slow). If you can't reproduce, add -Pvalidation.errorprone=true to slow down javac even more :) ``` diff --git a/lucene/facet/src/test/org/apache/lucene/facet/SlowDirectory.java b/lucene/facet/src/test/org/apache/lucene/facet/SlowDirectory.java index a809ea1e711..d5d4f52bbb0 100644 --- a/lucene/facet/src/test/org/apache/lucene/facet/SlowDirectory.java +++ b/lucene/facet/src/test/org/apache/lucene/facet/SlowDirectory.java @@ -27,7 +27,7 @@ import org.apache.lucene.util.ThreadInterruptedException; /** Test utility - slow directory */ // TODO: move to test-framework and sometimes use in tests? -public class SlowDirectory extends FilterDirectory { +public class SlowDirectory extends FilterDirectory { X private static final int IO_SLEEP_THRESHOLD = 50; ``` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org