rmuir commented on code in PR #12010:
URL: https://github.com/apache/lucene/pull/12010#discussion_r1046028135
##########
lucene/core/src/test/org/apache/lucene/codecs/lucene90/TestLucene90PointsFormat.java:
##########
@@ -98,7 +98,8 @@ public void testMergeStability() throws Exception {
super.testMergeStability();
}
- @SuppressWarnings("NarrowCalculation")
+ // TODO: clean up the math/estimation here rather than suppress so many
warnings
+ @SuppressWarnings({"NarrowCalculation", "LongDoubleConversion"})
Review Comment:
i think in general this test needs some cleanup (I suppressed it for
narrow-calculation, too). It is testing an "estimation" but in an exact manner,
which is fine, but its also a randomized test and doing some sneaky stuff.
I'd rather not cause a bunch of intermittent test failures by mucking around
with it in its current state, it would be better to get refactored by someone
that understands what it is doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
