msokolov commented on code in PR #11860: URL: https://github.com/apache/lucene/pull/11860#discussion_r1042658193
########## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/ExpandingVectorValues.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.backward_codecs.lucene94; + +import java.io.IOException; +import org.apache.lucene.index.FilterVectorValues; +import org.apache.lucene.index.VectorValues; +import org.apache.lucene.util.BytesRef; + +/** reads from byte-encoded data */ +public class ExpandingVectorValues extends FilterVectorValues { + + private final float[] value; + + /** + * Constructs ExpandingVectorValues with passed byte encoded VectorValues iterator + * + * @param in the wrapped values + */ + protected ExpandingVectorValues(VectorValues in) { Review Comment: @rmuir I ... hear your frustration, and. I'm sorry if I mocked you; I also get frustrated. > I raised this on the original PR and it was just totally **ignored** I do see there was no comment directly addressing yours, back in that other issue, but I think the substance *was* addressed, at least in part. We're *not* doing any quantization (that was originally an idea that got floated, and then discarded). I guess this ExpandingVectorValues is doing the opposite of quantization (no information loss)? And there was some reasonable discussion here about how to eliminate even that. I guess Ben is planning a more radical refactor, which ... I guess I would prefer to see separately, but @benwtrent you're doing the work, if you want to combine, we can review a larger change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
