rmuir commented on PR #11985: URL: https://github.com/apache/lucene/pull/11985#issuecomment-1331604920
i'm not opposed to the PR, just disagree with the bug or trap aspect. To me this is just a micro-optimization and I'm questioning the need to make anything abstract in our APIs (which makes them harder to implement). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org