uschindler commented on PR #11982: URL: https://github.com/apache/lucene/pull/11982#issuecomment-1331265646
In addition: The patch only removes the position on the duplicate, so the duplicates are still there. Unless you only read small arrays with 1 or 2 longs, there postion call cannot have too much overhead. The PR here is more a cleanup but actually it only replaces position() by the absolute parameter. As we still work on a suplicate, we cave to read the position() anyways. So this PR is just a cleanup, but (see std dev) not an improvement. What I like is your code to create the buffer views, by using streams with method references it is better to read, but the use of positional read on the view vs. postion + relative read can't have much effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
