rmuir opened a new pull request, #11977: URL: https://github.com/apache/lucene/pull/11977
In this test, `in` member is always a fresh `char []`: test uses the wrong equals. ``` /home/rmuir/workspace/lucene/lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/TestSynonymGraphFilter.java:1404: error: [ArrayEquals] Reference equality used to compare arrays if (syn1.in.equals(syn2.in)) { ^ (see https://errorprone.info/bugpattern/ArrayEquals) Did you mean 'if (Arrays.equals(syn1.in, syn2.in)) {'? ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org