gsmiller commented on code in PR #11950:
URL: https://github.com/apache/lucene/pull/11950#discussion_r1029458836


##########
lucene/core/src/test/org/apache/lucene/search/TestRangeFieldsDocValuesQuery.java:
##########
@@ -226,4 +228,30 @@ public void testToString() {
     Query q4 = LongRangeDocValuesField.newSlowIntersectsQuery("foo", longMin, 
longMax);
     assertEquals("foo:[[101, 124, 137] TO [138, 145, 156]]", q4.toString());
   }
+
+  public void testNoData() throws IOException {
+    Directory dir = newDirectory();

Review Comment:
   Yeah, that's a nice pattern and a good suggestion. I'd prefer to be 
consistent though with the approach taken by the other unit tests in this 
class, and would rather not increase the scope of this bug fix to include 
changing the resource management in all these unit tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to