stefanvodita commented on PR #11815: URL: https://github.com/apache/lucene/pull/11815#issuecomment-1321267832
Thank you for the ideas @zhaih , I’ve incorporated all of them. Your suggestion of using `ByteRef` in the keyset led to me finding a bug in the tests. The index creation methods didn’t delete any docs because I had stored the "delete" marker in a `BinaryDocValuesField`. That’s fixed now and the tests are more thorough with their checks. @mikemccand , I don’t know how doc-values updates work. Why would they not be covered by this solution? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
