shubhamvishu opened a new pull request, #11954: URL: https://github.com/apache/lucene/pull/11954
### Description This removes the method `QueryTimeout#isTimeoutEnabled` and moves the responsibility to ensure timeout is not null to the caller. Initially I went with the approach to allow `QueryTimeout` to be null (and removing `#isTimeoutEnabled`) and allow wrapping `TimeLimitingBulkScorer` and `ExitableDirectoryReader` with null timeouts which is equivalent of timeout not enabled as this makes work easy for the caller but giving a thought again it made more sense to only wrap the classes if there is an actual timeout and moving the responsibility to ensure timeout is configured to caller method as mentioned in the issue. Closes #11914 <!-- If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide. https://github.com/apache/lucene/blob/main/CONTRIBUTING.md --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
