gsmiller commented on code in PR #11928: URL: https://github.com/apache/lucene/pull/11928#discussion_r1026737221
########## lucene/core/src/java/org/apache/lucene/search/DisjunctionDISIApproximation.java: ########## @@ -45,29 +51,54 @@ public long cost() { @Override public int docID() { - return subIterators.top().doc; + return docID; } - @Override - public int nextDoc() throws IOException { + private int doNext(int target) throws IOException { + if (target == DocIdSetIterator.NO_MORE_DOCS) { + docID = DocIdSetIterator.NO_MORE_DOCS; + return docID; + } Review Comment: That's fair. I removed the check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org