rmuir commented on PR #11927:
URL: https://github.com/apache/lucene/pull/11927#issuecomment-1316010019
The problem is this piece:
```
tasks.withType(JavaCompile) { JavaCompile task ->
task.options.forkOptions.jvmArgs += vmOpts
}
```
There are 3 cases:
* JavaCompile with native toolchain: no forking happens, this is a no-op
* JavaCompile when using error-prone: executable is `java` so this code
works and does the right thing
* JavaCompile when using alternate toolchain: executable is `javac` so it
needs tweaking (prefix `-J` to args) <-- this case is untested and buggy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
