jtibshirani commented on PR #11861: URL: https://github.com/apache/lucene/pull/11861#issuecomment-1282872442
As a note, this only touches the read codepath and has no effect on data format, so it's safe to fix the current codec directly. I tried to add a test but didn't see a good way: * The bug is only triggered when you add over 2GB of vector data -- this is much too slow for unit tests! * I also tried exposing `validateFieldEntry`, removing tricky dependencies like `FieldEntry`, and testing that directly... but it didn't seem very helpful. Let me know if you have suggestions on testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
