rmuir commented on code in PR #11852: URL: https://github.com/apache/lucene/pull/11852#discussion_r995094470
########## gradle/testing/randomization/policies/luke-tests.policy: ########## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +// Policy file for :lucene:luke tests. Please keep minimal and avoid wildcards. +// this differs from the standard lucene policy in that it must allow opening port 8080 +// and allow JDK logging configuration. Review Comment: This won't work: port 8080 might be busy doing other things. Or in TIME_WAIT state from a previous test run. We can't bind to any specific port in tests. Please, make the port configurable... and in tests bind to port 0, so that you get a spare port in a race-free way. Call getAddress() afterwards to find out which port you were allocated, and connect to that in the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
