nknize commented on issue #11824: URL: https://github.com/apache/lucene/issues/11824#issuecomment-1260938633
What's annoying is how incredibly trappy this override logic is. That a method call literally moving from `createWeight` to `getScorerSupplier` results in a 72.2% regression even slipped by me before merge doesn't bode well for new committers. And then it sat in regression until an entire company was interested in releasing. I wonder if we can do better? Like maybe figure out better guardrails in these methods? Perhaps by something as simple as a rename to signal one happens per segment? This isn't the first and will certainly not be the last time an expensive operation accidentally slips to a critical path. Any other ideas how to lower the bar here for new committers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
