uschindler commented on issue #11827: URL: https://github.com/apache/lucene/issues/11827#issuecomment-1260501918
I fully agree, some checks should be done. But here are a few bits that came into my mind: - The @mikemccand benchmarks are running against main branch only. So the first check should be *before* creating the release branch, so we know that the start of branch is "clean". - Anything else that gets included into release branch should be monitored by the RM if it negatively affects perf on main. - Is there a benchmark available for the 9.x branch? If it would be configurable / modular we could have a base branch (against main and in parallel against 9.x). When a release branch is created we could compare the changes on the release branch with the baselines!? These are just ideas, but basically the important thing would be: Before creating the release branch do a quick check through the benchmark suite on Mike's web page and find potential issues. During the release process when stuff is merged into release branch monitor all merged changes manually on main's benchmark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
