gautamworah96 commented on code in PR #11796: URL: https://github.com/apache/lucene/pull/11796#discussion_r975969527
########## lucene/core/src/java/org/apache/lucene/store/ByteTrackingIndexOutput.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.store; + +import java.io.IOException; +import java.util.concurrent.atomic.AtomicLong; + +/** An {@link IndexOutput} that wraps another instance and tracks the number of bytes written */ +public class ByteTrackingIndexOutput extends IndexOutput { + + private final IndexOutput output; + private final AtomicLong byteTracker; + + protected ByteTrackingIndexOutput(IndexOutput output, AtomicLong byteTracker) { + super( + "Byte tracking wrapper for: " + output.getName(), + "ByteTrackingIndexOutput{" + output.getName() + "}"); + this.output = output; + this.byteTracker = byteTracker; + } + + @Override + public void writeByte(byte b) throws IOException { + byteTracker.incrementAndGet(); + output.writeByte(b); + } + + @Override + public void writeBytes(byte[] b, int offset, int length) throws IOException { + byteTracker.addAndGet(length); + output.writeBytes(b, offset, length); + } + + @Override + public void close() throws IOException { + output.close(); + } + + @Override + public long getFilePointer() { + return output.getFilePointer(); + } + + @Override + public long getChecksum() throws IOException { + return output.getChecksum(); + } + + public String getWrappedName() { Review Comment: Why do we need `getWrappedName` and `getWrappedToString`? They are already defined in the parent class ########## lucene/core/src/java/org/apache/lucene/store/ByteTrackingIndexOutput.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.store; + +import java.io.IOException; +import java.util.concurrent.atomic.AtomicLong; + +/** An {@link IndexOutput} that wraps another instance and tracks the number of bytes written */ +public class ByteTrackingIndexOutput extends IndexOutput { + + private final IndexOutput output; + private final AtomicLong byteTracker; + + protected ByteTrackingIndexOutput(IndexOutput output, AtomicLong byteTracker) { + super( + "Byte tracking wrapper for: " + output.getName(), + "ByteTrackingIndexOutput{" + output.getName() + "}"); + this.output = output; + this.byteTracker = byteTracker; + } + + @Override + public void writeByte(byte b) throws IOException { + byteTracker.incrementAndGet(); Review Comment: We are not using the returned value here. Just use `increment` maybe? Same for the `writeBytes` method? ########## lucene/core/src/java/org/apache/lucene/store/WriteAmplificationTrackingDirectoryWrapper.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.store; + +import java.io.IOException; +import java.util.concurrent.atomic.AtomicLong; + +/** {@link FilterDirectory} that tracks write amplification factor */ +public final class WriteAmplificationTrackingDirectoryWrapper extends FilterDirectory { + + private final AtomicLong flushedBytes = new AtomicLong(); + private final AtomicLong mergedBytes = new AtomicLong(); + + /** + * Sole constructor, typically called from sub-classes. + * + * @param in input Directory + */ + public WriteAmplificationTrackingDirectoryWrapper(Directory in) { + super(in); + } + + @Override + public IndexOutput createOutput(String name, IOContext context) throws IOException { + IndexOutput output = in.createOutput(name, context); + IndexOutput byteTrackingIndexOutput; + if (context.context.equals(IOContext.Context.FLUSH)) { + byteTrackingIndexOutput = new ByteTrackingIndexOutput(output, flushedBytes); + } else if (context.context.equals(IOContext.Context.MERGE)) { + byteTrackingIndexOutput = new ByteTrackingIndexOutput(output, mergedBytes); + } else { + return output; + } + return byteTrackingIndexOutput; + } + + public double getApproximateWriteAmplificationFactor() { Review Comment: We can make this method static by 0 initializing the counters and making them static in L25-26 ########## lucene/core/src/java/org/apache/lucene/store/ByteTrackingIndexOutput.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.store; + +import java.io.IOException; +import java.util.concurrent.atomic.AtomicLong; + +/** An {@link IndexOutput} that wraps another instance and tracks the number of bytes written */ +public class ByteTrackingIndexOutput extends IndexOutput { + + private final IndexOutput output; + private final AtomicLong byteTracker; + + protected ByteTrackingIndexOutput(IndexOutput output, AtomicLong byteTracker) { + super( + "Byte tracking wrapper for: " + output.getName(), + "ByteTrackingIndexOutput{" + output.getName() + "}"); + this.output = output; + this.byteTracker = byteTracker; + } + + @Override + public void writeByte(byte b) throws IOException { + byteTracker.incrementAndGet(); + output.writeByte(b); + } + + @Override + public void writeBytes(byte[] b, int offset, int length) throws IOException { + byteTracker.addAndGet(length); + output.writeBytes(b, offset, length); + } + + @Override + public void close() throws IOException { Review Comment: It is annoying that we have to unnecessarily write all these empty method that just override things. Is there a way to not do this? Just something to think about. No specific suggestion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
