[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #11743: LUCENE-10592 Better estimate memory for HNSW graph

[GitBox]

mayya-sharipova commented on code in PR #11743:
URL: https://github.com/apache/lucene/pull/11743#discussion_r966265177


##########
lucene/core/src/test/org/apache/lucene/util/hnsw/TestHnswGraph.java:
##########
@@ -74,12 +74,8 @@ public void setup() {
     similarityFunction =
         VectorSimilarityFunction.values()[
             random().nextInt(VectorSimilarityFunction.values().length - 1) + 
1];
-    if (similarityFunction == VectorSimilarityFunction.DOT_PRODUCT) {
-      vectorEncoding =
-          
VectorEncoding.values()[random().nextInt(VectorEncoding.values().length - 1) + 
1];
-    } else {
-      vectorEncoding = VectorEncoding.FLOAT32;
-    }
+    vectorEncoding =
+        
VectorEncoding.values()[random().nextInt(VectorEncoding.values().length - 1) + 
1];

Review Comment:
   Great feedback! Thanks Adrien & Dawid!  Addressed in 
45ced1e5beac8eb9932933967f3a2ca00d0c7835



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org