javanna commented on issue #11393: URL: https://github.com/apache/lucene/issues/11393#issuecomment-1232694645
@jpountz I am looking into fixing the points issue that I mentioned above. We could for instance ensure that `Lucene90PointsReader` never returns `null` and instead return an empty instance. On the other hand it looks like many callers of this method already check for `null`, and I see that `getValues` also throws exception in case `FieldInfo#getPointDimensionCount` is `0`, which means that callers can't blindly call `getValues` without consulting `FieldInfo` first. I wonder then, should we fix `FieldExistsQuery` to handle the null return value, or adapt all other existing callers to not handle null? I think the former is quicker, the latter is cleaner, especially if like you said above "codec APIs are required to return non-null empty instances on fields that have the feature turned on on their FieldInfo, even if all values have been merged away." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
