msokolov commented on code in PR #1054:
URL: https://github.com/apache/lucene/pull/1054#discussion_r949257124
##########
lucene/core/src/java/org/apache/lucene/document/KnnVectorField.java:
##########
@@ -117,6 +160,21 @@ public KnnVectorField(String name, float[] vector,
FieldType fieldType) {
fieldsData = vector;
}
+ /**
+ * Creates a numeric vector field. Fields are single-valued: each document
has either one value or
+ * no value. Vectors of a single field share the same dimension and
similarity function.
+ *
+ * @param name field name
+ * @param vector value
+ * @param fieldType field type
+ * @throws IllegalArgumentException if any parameter is null, or the vector
is empty or has
+ * dimension > 1024.
+ */
+ public KnnVectorField(String name, BytesRef vector, FieldType fieldType) {
Review Comment:
good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
