msokolov commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r939674449
##########
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##########
@@ -730,4 +794,61 @@ protected int comparePivot(int j) {
return Float.compare(score[pivot], score[j]);
}
}
+
+ private static class SelectiveQuery extends Query {
+
+ public float selectivity = 1f;
+ private FixedBitSet selectedBits;
+ private long cost;
+
+ @SuppressForbidden(reason = "Uses Math.random()")
Review Comment:
Hi Kaival - would you mind opening a new issue or maybe just a PR where we
can discuss? I went looking for this comment and had a little trouble figuring
out where it was, I guess because this PR is closed it no longer shows up on
the list of open PRs, duh.
As for the specifics of the proposal, your ideas seem good, but (1) I am
trying to push another PR for handling low-precision vector quantization that
will make a number of changes to the existing KnnGraphTester -sorry! but can
you think about also incorporating those changes? and (2) maybe a smaller
refactor exposing a function that accepts all the needed arguments (that can be
called from a main that gets its args somehow without changing any of the other
implementation details would be a good first step? And then we could have an
actual unit test so that we can ensure that other changes are safe. And then we
could start restructuring the internals to make it better? We could also change
command-line parsing if it seems better to do it some other way, but can we do
these as separate PRs please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
