tang-hi commented on PR #1016: URL: https://github.com/apache/lucene/pull/1016#issuecomment-1201341143
> > I think we should keep the simple `toDot` and not try to coerce graphviz in a special way with magic like this. It has a lot of options to tweak its output. > > Biggest win to make the automata more readable visually is to add back the missing removal of dead states to LevensteinAutomata.java, we should do this at the end: > > ``` > automata = Operations.removeDeadStates(automata); > ``` > > It seems this was lost in a refactoring. I compare the state between `use bfs` and `not use bfs`.It seems like bfs has little effect when dead state is included. So I think keep the simple `toDot` is a good idea. I will restore `Automaton.java` in this pr. And may be open a new pr to add back `Operations.removeDeadStates(automata);`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
