[
https://issues.apache.org/jira/browse/LUCENE-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573029#comment-17573029
]
Michael Sokolov commented on LUCENE-10662:
------------------------------------------
> They can do of course, if LuceneTestCase doesn't extend org.junit.Assert, one
> can easily define an intermediate abstract class between LuceneTestCase and
> their actual test classes and
Why is it necessary to break the inheritance in order to achieve what is wanted
here? Can't we leave LuceneTestCase alone, and define MyLuceneTestCase extends
LuceneTestCase which implements its own static methods `assertWhatever` that is
defined to explicitly call `assertj` implementation. Then implementers of
`MyLuceneTestCase` can get the definition they want, and no changes are
required in Lucene. Maybe if you are not currently inheriting from
LuceneTestCase, you must change to inherit from MyLuceneTestCase, but that is a
small change compared to what is contemplated here.
> Make LuceneTestCase to not extend from org.junit.Assert
> -------------------------------------------------------
>
> Key: LUCENE-10662
> URL: https://issues.apache.org/jira/browse/LUCENE-10662
> Project: Lucene - Core
> Issue Type: Test
> Components: general/test
> Reporter: Marios Trivyzas
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Since *LuceneTestCase* is a very useful abstract class that can be extended
> and used by many projects, having it extending *org.junit.Assert* limits all
> users to exclusively use the static methods of {*}org.junit.Assert{*}. In our
> project we want to use [https://joel-costigliola.github.io/assertj] where the
> main method to call is *org.assertj.core.api.Assertions.assertThat* which
> conflicts with the deprecated {*}org.junit.Assert.assertThat{*}, recognized
> by default by the compiler. So one can only use assertj if on every call uses
> fully qualified name for the *assertThat* method, i.e.
>
> {code:java}
> org.assertj.core.api.Assertions.assertThat(myObj.name()).isEqualTo(expectedName)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
