[
https://issues.apache.org/jira/browse/LUCENE-10658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572582#comment-17572582
]
Vigya Sharma commented on LUCENE-10658:
---------------------------------------
Good point.. We use pooled readers and interrupting those threads could make
the readers invalid. Thanks for sharing this Adrien!
Adding here for reference, per java docs:
{quote}Accessing this class either directly or indirectly from a thread while
it's interrupted can close the underlying file descriptor immediately if at the
same time the thread is blocked on IO. The file descriptor will remain closed
and subsequent access to
[{{NIOFSDirectory}}|https://lucene.apache.org/core/5_2_0/core/org/apache/lucene/store/NIOFSDirectory.html]
will throw a
[{{ClosedChannelException}}|http://download.oracle.com/javase/7/docs/api/java/nio/channels/ClosedChannelException.html?is-external=true].
{quote}
> Merges should periodically check for abort
> ------------------------------------------
>
> Key: LUCENE-10658
> URL: https://issues.apache.org/jira/browse/LUCENE-10658
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/index
> Affects Versions: 9.3
> Reporter: Nhat Nguyen
> Priority: Major
>
> Rolling back an IndexWriter without committing shouldn't take long (i.e.,
> less than several seconds), and Elasticsearch cluster coordination [relies
> on|https://github.com/elastic/elasticsearch/issues/88055] this assumption. If
> some merges are taking place, the rollback can take several minutes as merges
> only check for abort when writing to files via
> [MergeRateLimiter|https://github.com/apache/lucene/blob/3d7d85f245381f84c46c766119695a8645cde2b8/lucene/core/src/java/org/apache/lucene/index/MergeRateLimiter.java#L117-L119].
> Merging a completion field, for example, can take a long time without
> touching output files. Another reason merges should periodically check for
> abort is its outputs will be discarded.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
