mikemccand commented on PR #1017: URL: https://github.com/apache/lucene/pull/1017#issuecomment-1198181209
I cannot really understand the exciting geo-speak about centroids and bounding boxes :) It all sounds really cool though. But +1 to take a progress-not-perfection (PNP) approach here. This is exactly why we have the `@lucene.experimental` tag, to enable iterative innovation for fun new features like this. Maybe we could implement both Elastic's battle-tested (2 years in production) approach, and this new approach, and then over time cross-fertilize between the two? We have multiple highlighters, query-parsers, suggesters, etc. -- it's healthy. Perhaps over time we boil it down to a single "best of both" solution, or perhaps not. Basically we don't have to settle all of these differences right now at this PR. This PR is already adding an awesome feature to Lucene. We can commit this (once important feedback is addressed) and then PNP iterate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
