[ https://issues.apache.org/jira/browse/LUCENE-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565380#comment-17565380 ]
Adrien Grand commented on LUCENE-10653: --------------------------------------- +1 to doing a bulk heapify The fact that this scorer only handles 2 clauses for now is only a way to give us more time to evaluate when we should use it vs. WANDScorer in my opinion. Most likely it will be used for more than 2 clauses at some point in the future. > Should BlockMaxMaxscoreScorer rebuild its heap in bulk? > ------------------------------------------------------- > > Key: LUCENE-10653 > URL: https://issues.apache.org/jira/browse/LUCENE-10653 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search > Reporter: Greg Miller > Priority: Minor > > BMMScorer has to frequently rebuild its heap, and does do by clearing and > then iteratively calling {{{}add{}}}. It would be more efficient to heapify > in bulk. This is more academic than anything right now though since BMMScorer > is only used with two-clause disjunctions, so it's sort of a silly > optimization if it's not supporting a greater number of clauses. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org