jpountz commented on code in PR #996: URL: https://github.com/apache/lucene/pull/996#discussion_r912762557
########## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ########## @@ -85,7 +85,11 @@ public class IndexSearcher { private static QueryCache DEFAULT_QUERY_CACHE; private static QueryCachingPolicy DEFAULT_CACHING_POLICY = new UsageTrackingQueryCachingPolicy(); private QueryTimeout queryTimeout = null; - private boolean partialResult = false; + // TODO: does partialResult need to be volatile? It can be set on one of the threads of the Review Comment: Agreed, I'll keep the comment but remove the TODO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org