Yuti-G commented on code in PR #974:
URL: https://github.com/apache/lucene/pull/974#discussion_r912548774
##########
lucene/demo/src/java/org/apache/lucene/demo/facet/DistanceFacetsExample.java:
##########
@@ -212,7 +212,26 @@ public static Query getBoundingBoxQuery(
}
/** User runs a query and counts facets. */
- public FacetResult search() throws IOException {
+ public FacetResult searchAllChildren() throws IOException {
+
+ FacetsCollector fc = searcher.search(new MatchAllDocsQuery(), new
FacetsCollectorManager());
+
+ Facets facets =
+ new DoubleRangeFacetCounts(
+ "field",
+ getDistanceValueSource(),
+ fc,
+ getBoundingBoxQuery(ORIGIN_LATITUDE, ORIGIN_LONGITUDE, 10.0),
+ ONE_KM,
+ TWO_KM,
+ FIVE_KM,
+ TEN_KM);
+
+ return facets.getAllChildren("field");
+ }
+
+ /** User runs a query and counts facets. */
+ public FacetResult searchTopChildren() throws IOException {
Review Comment:
Hmmm, I think the added example is intending to do what you described. It is
faceting on one-hour bucket and tracing the error message in each one-hour slot
from the past 168 hours (entire week). Only the first range (past `0-1` hour)
has an end point as now. For better understanding, I changed the starting index
in the range label to start from (0-1) hour in the latest commit.
For example, if I call `getAllChildren("error log")`, the results are:
```
dim=error log path=[] value=2758 childCount=168
Past 0-1 hour (0)
Past 1-2 hour (1)
Past 2-3 hour (2)
Past 3-4 hour (3)
Past 4-5 hour (4)
Past 5-6 hour (5)
Past 6-7 hour (6)
Past 7-8 hour (7)
Past 8-9 hour (8)
Past 9-10 hour (9)
Past 10-11 hour (10)
Past 11-12 hour (11)
Past 12-13 hour (12)
Past 13-14 hour (13)
Past 14-15 hour (14)
Past 15-16 hour (15)
Past 16-17 hour (16)
Past 17-18 hour (17)
Past 18-19 hour (18)
Past 19-20 hour (19)
Past 20-21 hour (20)
Past 21-22 hour (21)
Past 22-23 hour (22)
Past 23-24 hour (23)
Past 24-25 hour (24)
Past 25-26 hour (25)
Past 26-27 hour (26)
Past 27-28 hour (27)
Past 28-29 hour (28)
Past 29-30 hour (29)
Past 30-31 hour (30)
Past 31-32 hour (31)
Past 32-33 hour (32)
Past 33-34 hour (33)
Past 34-35 hour (34)
Past 35-36 hour (0)
Past 36-37 hour (1)
Past 37-38 hour (2)
Past 38-39 hour (3)
Past 39-40 hour (4)
Past 40-41 hour (5)
Past 41-42 hour (6)
Past 42-43 hour (7)
Past 43-44 hour (8)
Past 44-45 hour (9)
Past 45-46 hour (10)
Past 46-47 hour (11)
Past 47-48 hour (12)
Past 48-49 hour (13)
Past 49-50 hour (14)
Past 50-51 hour (15)
Past 51-52 hour (16)
Past 52-53 hour (17)
Past 53-54 hour (18)
Past 54-55 hour (19)
Past 55-56 hour (20)
Past 56-57 hour (21)
Past 57-58 hour (22)
Past 58-59 hour (23)
Past 59-60 hour (24)
Past 60-61 hour (25)
Past 61-62 hour (26)
Past 62-63 hour (27)
Past 63-64 hour (28)
Past 64-65 hour (29)
Past 65-66 hour (30)
Past 66-67 hour (31)
Past 67-68 hour (32)
Past 68-69 hour (33)
Past 69-70 hour (34)
Past 70-71 hour (0)
Past 71-72 hour (1)
Past 72-73 hour (2)
Past 73-74 hour (3)
Past 74-75 hour (4)
Past 75-76 hour (5)
Past 76-77 hour (6)
Past 77-78 hour (7)
Past 78-79 hour (8)
Past 79-80 hour (9)
Past 80-81 hour (10)
Past 81-82 hour (11)
Past 82-83 hour (12)
Past 83-84 hour (13)
Past 84-85 hour (14)
Past 85-86 hour (15)
Past 86-87 hour (16)
Past 87-88 hour (17)
Past 88-89 hour (18)
Past 89-90 hour (19)
Past 90-91 hour (20)
Past 91-92 hour (21)
Past 92-93 hour (22)
Past 93-94 hour (23)
Past 94-95 hour (24)
Past 95-96 hour (25)
Past 96-97 hour (26)
Past 97-98 hour (27)
Past 98-99 hour (28)
Past 99-100 hour (29)
Past 100-101 hour (30)
Past 101-102 hour (31)
Past 102-103 hour (32)
Past 103-104 hour (33)
Past 104-105 hour (34)
Past 105-106 hour (0)
Past 106-107 hour (1)
Past 107-108 hour (2)
Past 108-109 hour (3)
Past 109-110 hour (4)
Past 110-111 hour (5)
Past 111-112 hour (6)
Past 112-113 hour (7)
Past 113-114 hour (8)
Past 114-115 hour (9)
Past 115-116 hour (10)
Past 116-117 hour (11)
Past 117-118 hour (12)
Past 118-119 hour (13)
Past 119-120 hour (14)
Past 120-121 hour (15)
Past 121-122 hour (16)
Past 122-123 hour (17)
Past 123-124 hour (18)
Past 124-125 hour (19)
Past 125-126 hour (20)
Past 126-127 hour (21)
Past 127-128 hour (22)
Past 128-129 hour (23)
Past 129-130 hour (24)
Past 130-131 hour (25)
Past 131-132 hour (26)
Past 132-133 hour (27)
Past 133-134 hour (28)
Past 134-135 hour (29)
Past 135-136 hour (30)
Past 136-137 hour (31)
Past 137-138 hour (32)
Past 138-139 hour (33)
Past 139-140 hour (34)
Past 140-141 hour (0)
Past 141-142 hour (1)
Past 142-143 hour (2)
Past 143-144 hour (3)
Past 144-145 hour (4)
Past 145-146 hour (5)
Past 146-147 hour (6)
Past 147-148 hour (7)
Past 148-149 hour (8)
Past 149-150 hour (9)
Past 150-151 hour (10)
Past 151-152 hour (11)
Past 152-153 hour (12)
Past 153-154 hour (13)
Past 154-155 hour (14)
Past 155-156 hour (15)
Past 156-157 hour (16)
Past 157-158 hour (17)
Past 158-159 hour (18)
Past 159-160 hour (19)
Past 160-161 hour (20)
Past 161-162 hour (21)
Past 162-163 hour (22)
Past 163-164 hour (23)
Past 164-165 hour (24)
Past 165-166 hour (25)
Past 166-167 hour (26)
Past 167-168 hour (27)
```
If I call `getTopChildren(10, "error log")`, the results are
```
dim=error log path=[] value=2758 childCount=163
Past 104-105 hour (34)
Past 139-140 hour (34)
Past 34-35 hour (34)
Past 69-70 hour (34)
Past 103-104 hour (33)
Past 138-139 hour (33)
Past 33-34 hour (33)
Past 68-69 hour (33)
Past 102-103 hour (32)
Past 137-138 hour (32)
```
Please let me know if there is any question/issue, thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
