uschindler commented on code in PR #978: URL: https://github.com/apache/lucene/pull/978#discussion_r908184454
########## lucene/core/src/java/org/apache/lucene/util/Constants.java: ########## @@ -84,10 +97,27 @@ private Constants() {} // can't construct JRE_IS_64BIT = is64Bit; } - public static final boolean JRE_IS_MINIMUM_JAVA8 = - JVM_MAJOR_VERSION > 1 || (JVM_MAJOR_VERSION == 1 && JVM_MINOR_VERSION >= 8); - public static final boolean JRE_IS_MINIMUM_JAVA9 = - JVM_MAJOR_VERSION > 1 || (JVM_MAJOR_VERSION == 1 && JVM_MINOR_VERSION >= 9); - public static final boolean JRE_IS_MINIMUM_JAVA11 = Review Comment: This code for Java 11 was wrong anyways. Lucily it was not used at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org