jpountz commented on PR #964: URL: https://github.com/apache/lucene/pull/964#issuecomment-1160179472
Unfortunately this is challenging to do right at the moment since the API requires the collector to tell the `ScoreMode` it needs to be able to create the `Weight`. So either the collector says it needs to evaluate all hits (`ScoreMode.COMPLETE`) and then we cannot skip hits in the case when the weight can count its hits efficiently. Or it says it doesn't (`ScoreMode.TOP_SCORES`), like the PR does at the moment and then queries get slower when the weight cannot count hits. We could fix this by moving the score mode to `LeafCollector` instead of `Collector` but this would be a big change... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
