[
https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552851#comment-17552851
]
Greg Miller commented on LUCENE-10603:
--------------------------------------
OK, thanks [~ChrisLu]! +1 to doing this for consistency.
I took a pass at making this change within the faceting module since there are
a number of places we rely on SSDV ordinal iteration. I figured we could
probably tackle this change through multiple PRs, so I figured I'd lend a hand
with faceting: https://github.com/apache/lucene/pull/954
> Improve iteration of ords for SortedSetDocValues
> ------------------------------------------------
>
> Key: LUCENE-10603
> URL: https://issues.apache.org/jira/browse/LUCENE-10603
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Lu Xugang
> Priority: Trivial
> Time Spent: 10m
> Remaining Estimate: 0h
>
> After SortedSetDocValues#docValueCount added since Lucene 9.2, should we
> refactor the implementation of ords iterations using docValueCount instead of
> NO_MORE_ORDS?
> Similar how SortedNumericDocValues did
> From
> {code:java}
> for (long ord = values.nextOrd();ord != SortedSetDocValues.NO_MORE_ORDS; ord
> = values.nextOrd()) {
> }{code}
> to
> {code:java}
> for (int i = 0; i < values.docValueCount(); i++) {
> long ord = values.nextOrd();
> }{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
