uschindler commented on PR #941: URL: https://github.com/apache/lucene/pull/941#issuecomment-1146073671
> I wanted to ask exactly this point - the version check isn't new, it is already on main since #819. The check is not to prevent us from creating buggy Lucene releases. It is just there because Gradle won't run correctly. This is different to what you want to achieve here: Here we want to prevent Java bugs influence Lucene or Javadoc created. But to prevent that you need to check on the runtime version, not the gradle version. By default it is the same, but theoretically you could run with modern Java 17 and execute tests and build javadocs with a completely different version (and possibly an older version). I think the checks should be in the alternate JVM support gradle file. We're not talking here about Gradle runs/won't run, we are talking here about the Java version to execute javac/javadoc/tests. And this one is not necessarily the one of Gradle so the check is at wrong place. So I am fine with current patch, but the MAXIMUM version must be 17 also on 9.x (11 till 17). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
