Deepika0510 commented on code in PR #927: URL: https://github.com/apache/lucene/pull/927#discussion_r888800914
########## lucene/core/src/test/org/apache/lucene/search/TestTimeLimitingBulkScorer.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.search; + +import org.apache.lucene.document.Document; +import org.apache.lucene.document.Field; +import org.apache.lucene.index.*; +import org.apache.lucene.store.Directory; +import org.apache.lucene.tests.analysis.MockAnalyzer; +import org.apache.lucene.tests.util.LuceneTestCase; + +/** Tests the {@link TimeLimitingBulkScorer}. */ +@LuceneTestCase.SuppressSysoutChecks( + bugUrl = "http://test.is.timing.sensitive.so.it.prints.instead.of.failing";) +public class TestTimeLimitingBulkScorer extends LuceneTestCase { + + public void testTimeLimitingBulkScorer() throws Exception { + Directory directory = newDirectory(); + IndexWriter writer = + new IndexWriter(directory, newIndexWriterConfig(new MockAnalyzer(random()))); + int n = 10000; + for (int i = 0; i < n; i++) { + Document d = new Document(); + d.add(newTextField("default", "ones ", Field.Store.YES)); + writer.addDocument(d); + } + writer.forceMerge(1); + writer.commit(); + writer.close(); + + DirectoryReader directoryReader; + IndexSearcher searcher; + TopDocs top; + ScoreDoc[] hits = null; + + Query query = new TermQuery(new Term("default", "ones")); + directoryReader = DirectoryReader.open(directory); + searcher = new IndexSearcher(directoryReader); + top = searcher.search(query, n, 5); + + if (top != null) { + hits = top.scoreDocs; + assertTrue("Partial result", hits.length > 0 && hits.length < n); Review Comment: I agree that timing tests are tricky to handle. The other options of `QueryTimeout` implementation would be to use `infiniteQueryTimeout`() and `immediateQueryTimeout`() (as used in `TestExitableDirectoryReader`) but these won't help in receiving partial results (as `infiniteQueryTimeout`() would lead to total n number of results and `immediateQueryTimeout`() would lead to 0 result). This would defy the purpose of the assertion used here, so what should be our take on this? Should we consider modifying the assertions or removing them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
