Yuti-G commented on PR #777: URL: https://github.com/apache/lucene/pull/777#issuecomment-1133481903
> This looks great! Thanks @Yuti-G! It would be nice if we could create a common abstract class to hold some of the common logic between this and the non-concurrent implementation. Seems like a lot of copy/paste going on. This isn't a new problem though, so let's not do that work as part of this PR. What do you think of opening a separate issue to see if we can consolidate some common logic? You probably have a better idea of how feasible this is after working on these changes, so I'm curious what you think. Thanks again for taking this on! Thanks @gsmiller for the great idea! I will open a separate issue to consolidate the common logic between ConcurrentSSDVFacetCounts and SSDVFacetCounts after LUCENE-10550 are merged. There are many duplicate codes between these two classes in https://github.com/apache/lucene/pull/914 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
