romseygeek opened a new pull request, #894: URL: https://github.com/apache/lucene/pull/894
* ExternalRefSorter.ByteSequenceIterator should be public, as it's designed for external use * MatchRegionRetriever refers to a private class in its public javadoc. I've just removed the link for now, but we could think about making the private implementation public as it looks as though it may be useful for other implementations of the highlighter? * STMergingTermsEnum is now package-private. It uses private classes in some protected methods, and just making the whole thing package-private seemed to be the simplest solution to me. If we want to keep it public, then we should probably go through this more carefully and work out what needs to be available for extension and what doesn't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
