[
https://issues.apache.org/jira/browse/LUCENE-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531985#comment-17531985
]
Tomoko Uchida commented on LUCENE-10558:
----------------------------------------
Yes, the refactored constructor ignores the {{path}} when the sheme parameter
is {{{}CLASSPATH{}}}. The test for ConnectionCosts loads the default resource
on the classpath, and I didn't even imagine such a use-case that loads
arbitrary resources on the classpath...
I'm fine with exposing the new constructor with IOSupplier.
> Expose IOSupplier<InputStream> constructors in Kuromoji (and Nori?)
> -------------------------------------------------------------------
>
> Key: LUCENE-10558
> URL: https://issues.apache.org/jira/browse/LUCENE-10558
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael Sokolov
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When we refactored the constructors for these resource objects used by the
> kuromoji JapaneseTokenizer, we (inadvertently, I expect) changed the
> behavior for consumers that were supplying these resources on the classpath.
> In that case, we silently replaced the custom resources with the Lucene
> built-in ones. I think we cannot support the old API because of Java Module
> system restrictions, but we didn't provide any usable replacement or notice
> either.
>
> This issue is for exposing the new (private) constructors that accept
> streams, and adding a notice to Migration.md to point users at them, since
> they can be used with resources streams loaded from the classpath by the
> caller.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
