vigyasharma commented on PR #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1117847194
Removed the randomly returned high concurrency mergeSpec from
`findMerges(CodecReaders...)` in `MockRandomMergePolicy`. Added a check to
gracefully catch pending merges that are aborted before they start, due to a
closing `IndexWriter`. Such merges do not see any exceptions (since they never
started). We now catch them and fail the API with `MergePolicyException`
(aborted merges) instead of a less descriptive `RuntimeException`.
Ran the `TestAddIndexes` suite multiple times on repeat to catch concurrency
issues.
```python
% ./gradlew :lucene:core:test --tests
"org.apache.lucene.index.TestAddIndexes" -Dtests.iters=500
...
:lucene:core:test (SUCCESS): 17500 test(s)
The slowest tests (exceeding 500 ms) during this run:
2.77s TestAddIndexes.testCascadingMergesTriggered
{seed=[995488156EAA9213:C061B8FC39526277]} (:lucene:core)
2.57s TestAddIndexes.testCascadingMergesTriggered
{seed=[995488156EAA9213:6449415B81ED55E8]} (:lucene:core)
2.50s TestAddIndexes.testAddIndexesWithConcurrentMerges
{seed=[995488156EAA9213:8DDA90E4057EEECC]} (:lucene:core)
2.34s TestAddIndexes.testCascadingMergesTriggered
{seed=[995488156EAA9213:98ABD78A2EF738F8]} (:lucene:core)
1.86s TestAddIndexes.testCascadingMergesTriggered
{seed=[995488156EAA9213:F4015EAB7FEBE4C4]} (:lucene:core)
1.83s TestAddIndexes.testCascadingMergesTriggered
{seed=[995488156EAA9213:4C70D3A5B0897539]} (:lucene:core)
1.65s TestAddIndexes.testAddIndexesWithThreads
{seed=[995488156EAA9213:9168C57ACC52DE66]} (:lucene:core)
1.62s TestAddIndexes.testAddIndexesWithThreads
{seed=[995488156EAA9213:777C792E198970FF]} (:lucene:core)
1.53s TestAddIndexes.testAddIndexesWithRollback
{seed=[995488156EAA9213:FC3F09AFA640AEA1]} (:lucene:core)
1.53s TestAddIndexes.testAddIndexesWithRollback
{seed=[995488156EAA9213:CDD2AABCE4428929]} (:lucene:core)
The slowest suites (exceeding 1s) during this run:
1347.53s TestAddIndexes (:lucene:core)
BUILD SUCCESSFUL in 23m 4s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
