[ https://issues.apache.org/jira/browse/LUCENE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531851#comment-17531851 ]
Michael Sokolov commented on LUCENE-10335: ------------------------------------------ Thanks, Uwe, you're right I confused the issues. Maybe it was LUCENE-10400 that overrode the old behavior? And you are right, I am currently running into an issue with Kuromoji, not any other analyzer. Thank you for pointing out that we already have an InputStream constructor. I think we just need to make it public to support the use case we broke. Regarding migrate.txt, did you mean Migrate.md? Anyway I don't think there is any mention there of the change in behavior to ConnectionCosts and TokenInfoDictionary constructors. > IOUtils.getDecodingReader(Class<?>, String) is broken with modules > ------------------------------------------------------------------ > > Key: LUCENE-10335 > URL: https://issues.apache.org/jira/browse/LUCENE-10335 > Project: Lucene - Core > Issue Type: Bug > Reporter: Dawid Weiss > Assignee: Uwe Schindler > Priority: Major > Fix For: 9.1, 10.0 (main) > > Attachments: LUCENE-10335-1.patch, LUCENE-10335.patch, Screenshot > from 2021-12-25 18-04-55.png > > Time Spent: 18h 40m > Remaining Estimate: 0h > > This method calls clazz.getResourceAsStream() but in a modular application > the method won't see any of the resources in clazz's module, causing an NPE. > We should deprecate or even remove this method entirely, leaving only > getDecodingReader(InputStream) and opening the resource on the caller's side. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org