romseygeek commented on code in PR #860:
URL: https://github.com/apache/lucene/pull/860#discussion_r864686490


##########
lucene/core/src/java/org/apache/lucene/search/WANDScorer.java:
##########
@@ -86,7 +86,6 @@ static int scalingFactor(float f) {
    * sure we do not miss any matches.
    */
   static long scaleMaxScore(float maxScore, int scalingFactor) {
-    assert scalingFactor(maxScore) >= scalingFactor;

Review Comment:
   > However it is currently not illegal for a clause to return a higher score 
on a subset of doc IDs than on the entire doc ID space
   
   OK.  Maybe this is something we can think about restricting more in the 
future?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to