msokolov commented on code in PR #859: URL: https://github.com/apache/lucene/pull/859#discussion_r863048001
########## lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java: ########## @@ -56,7 +56,6 @@ public void testEquals() { Query filter1 = new TermQuery(new Term("id", "id1")); KnnVectorQuery q2 = new KnnVectorQuery("f1", new float[] {0, 1}, 10, filter1); - assertNotEquals(q2, q1); Review Comment: Nit: I think we do want to assert that equals is reflexive? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org